-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python cpp sync #4816
Python cpp sync #4816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
assert start_index <= end_index | ||
|
||
# sync ops append to the head of cpp_ops | ||
for index in range((start_index - 1 - 1), -1, -1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why start_index
needs to be minus with 2?
assert end_index is not None | ||
assert start_index <= end_index | ||
|
||
# sync ops append to the head of cpp_ops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like append from cpp_ops, not to cpp_ops?
fix: #4810
project: #4679