Fix bug in computing output size of IdentityOffsetProjection #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengli09
deleted the
fix-bug-in-identity-offset-projection-output-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output size of IdentityOffsetProjection depends on the size of the outer MixedLayer. And the same instance of IdentityOffsetProjection may serve as input for multiple MixedLayer with different sizes. Therefore, the output size of IdentityOffsetProjection should be set as 0.
原理是IdentityOffsetProjection的size要由外层的mixed layer决定，而且同一个IdentityOffsetProjection可能会用在不同的mixed layer里，所以size是没法预先算出的，因而要设成0.