Ensure name is not set in bias_attr in gru_step_naive_layer #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
请问是哪三个bias呢？能不能提一个issue来详细描述下这个问题呢？ |
luotao1
reviewed
Oct 16, 2017
| @@ -3679,6 +3679,11 @@ def gru_step_naive_layer(input, | |||
| if size is None: | |||
| size = input.size / 3 | |||
|
|
|||
| if bias_attr and bias_attr.attr.get("parameter_name", None) is not None: | |||
| raise ValueError("You should not specify the name of bias parameters. " | |||
| "Otherwise, the three bias will share the same " | |||
luotao1
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
nameis not set inbias_attringru_step_naive_layer. Otherwise, the three biases will share the same parameter unexpectedly.Fixes #4829