export feed/fetch variable method to Python #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiJune
force-pushed
the
pybind_feed_fetch_method
branch
from
7496a2b
to
5fe3f8f
Compare
JiayiFeng
reviewed
Oct 16, 2017
| feed_inputs.resize(index + 1); | ||
| } | ||
| // shared data with input tensor | ||
| feed_inputs[index].ShareDataWith<T>(input); |
There was a problem hiding this comment.
I tend to use CopyFrom() here, for I think a fed tensor shouldn't have a direct relationship with origin tensor. However, I could be wrong.
There was a problem hiding this comment.
FeedOp will make a copy of the data [code], so I believe it is okay for it to be shared here.
reyoung
reviewed
Oct 16, 2017
| // be created. | ||
| Variable* g_feed_value = GetGlobalScope().Var(var_name); | ||
| auto& feed_inputs = | ||
| *(g_feed_value->GetMutable<std::vector<paddle::framework::LoDTensor>>()); |
There was a problem hiding this comment.
Please use global typedefs here.
#include "paddle/framework/feed_fetch_type.h"
reyoung
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4836