-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.9.0 #484
Release v0.9.0 #484
Conversation
In some situation, for instance, in the virtual machine, it could happen.
* also refine install docs, too
* some bug fix for sparse matrix * a minor bug fix
* Add automatic check AVX in CMake * Add indent in FindAVX.cmake * Revise table format and some words in build docs * Update build docs * Update build docs
* Rerange Build docs & emphasize them in README.md * Rerange Build docs & emphasize them in README.md
* Update Readme * Update readme * Update readme
* Update readme * Apache 2.0
* add interface and unittest of RecurrentGradientMachine for the function of multiple Subsequence inlinks with unequal token length
#115) * support rectangle padding, stride, window and input for PoolProjection * Follow comments. 1. Remove start 2. refine img_pool_a/b.conf for test_NetworkCompare 3. Split unit test * Modify the test in img_layers.py
* Use C++ 11 atomic_flag in MacOS as spin lock * Add unittest for it.
* save the model file including git sha1
* If cmake -DWITH_AVX=OFF during configuration, should not compile the file src/hl_math.cc and src/hl_avx_functions.cc.
* added mnist demo * modified .gitignore for .project files * normalize pixel in mnist_provider.py and set use_gpu=0
* add interface and unittest for nce layer * follow comments
* fix DataProvider create function args bug Change-Id: I9e3a1c535c805bf30204a14aea8d5143ff534784 * remove PserverForPython.h which is not used Change-Id: I2b27f1f3c11a42766a92fc689f0f5f1f73ee1d70 * add internal document script Change-Id: Ia0fec79456caea0b271f9903cc13e8a3d32e0774
* hierarchical rnn document, add new config example * update inputs_type of label * add check for unsupported config * refine hierarchical document * refine doc title * update docs, fix paddle to PaddlePaddle * follow comments
* Fix bug in yield dictionary in DataProvider. * Also make virtualenv work in Paddle.
Fix Debian package name in ubuntu install docs.
Changes Unknown when pulling 75553e2 on release/v0.9.0 into ** on master**. |
Change demo datafile location by using CDN in baidu.
Changes Unknown when pulling f3d816d on release/v0.9.0 into ** on master**. |
merge bugfix #593 and # 597 from develop branch
Changes Unknown when pulling 5c76b26 on release/v0.9.0 into ** on master**. |
|
|
New Features中1-2分别是qijun、wangyang的。 New Features:
Improvement:
|
|
Bumping up version number
Changes Unknown when pulling 5b233fa on release/v0.9.0 into ** on master**. |
@wangkuiyi All things done for v0.9.0. Should it be merged to master release? |
|
||
## New Features: | ||
|
||
* Add some layers to Paddle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some layers to Paddle ==> New Layers
* maxout layer. | ||
* Support rectangle padding, stride, window and input for Pooling Operation. | ||
* Add —job=time in trainer, which can be used to print time info without compiler option -WITH_TIMER=ON. | ||
* Support Mac OS X Sierra by source code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mac OS X Sierra 确实可以build吗?我在Yosemite上build是过不了,因为google test的源码不够符合C++11的规范。如果我们号称支持Mac,就得做到没问题。如果我们稳定思路是Docker为唯一官方支持方式,这里最好不claim支持mac。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 我们的 Travis https://travis-ci.org/ 一直再跑Mac OS X的 build and test, 一直没问题 。
- 我已经使用Mac Sierra两个月了,一直没问题。用户Sierra build也没有问题:An build error in Mac os 10.12 #551
- 我认为build本身是没问题的,关键在于build 源码比较费心,容易出错。
我建议在Support Mac OS X Sierra by source code
后面加上
but [docker image](http://www.paddlepaddle.org/doc/build/docker_install.html) is officially recommended to install PaddlePaddle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我认为build本身是没问题的,关键在于build 源码比较费心,容易出错。
这“费心”是指什么?
Yosemite上出错和Sierra上可以编译通过,区别在哪儿呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
费心,指的是各种环境依赖容易导致源码编译失败。
Sierra == OS X 10.12 == My laptop => OK
El Capitan == OS X 10.11 == Travis OS X default => OK
Yosemite == OS X 10.10 == ? 之所以编译不过,原因肯定在于XCode自带的Clang版本不同,一直没有测试。
Travis OS X支持的各种版本其实很全,我们只使用了其中一个版本,后期可以考虑加上。
https://docs.travis-ci.com/user/osx-ci-environment/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果很希望这个工作进入release note,请加上你使用的Xcode的版本吧。
如果写入release note了,就不要注明docker是唯一支持的模式了。
|
||
## Improvements | ||
|
||
* Add travis-ci for macos. Enable swig unittest in travis. Skip travis-ci when only docs are changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis-ci ==> Travis-CI
macos ==> Mac OS X
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in another PR. #652
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Refine documentation in RELEASE.md
Changes Unknown when pulling 0ad33b5 on release/v0.9.0 into ** on master**. |
* Update setup.py * reorganize seq2seq * update lac dependency
* upgrade F.cross_entropy usage * fix sample code bug * fix ppl shape error
Release Note
TODO @backyes @qingqing01 @hedaoyuan @gangliao Please add release note here.
QA Testing