Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify executor #4855

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Simplify executor #4855

merged 2 commits into from
Oct 18, 2017

Conversation

tonyyang-svail
Copy link

No description provided.

wangkuiyi
wangkuiyi approved these changes Oct 17, 2017
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR for removing the Prune function?

@tonyyang-svail
Copy link
Author

Yes, mainly for removing prune (you can find a PR for prune here).
Also, minor change on where to create variables. After this PR, all the persistent variables are created in the global scope and everything else in the local scope.

@tonyyang-svail
Copy link
Author

merged. Later on, python test will be added by @reyoung

@tonyyang-svail tonyyang-svail merged commit 43c05e4 into PaddlePaddle:develop Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

@QiJune QiJune Awaiting requested review from QiJune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonyyang-svail @wangkuiyi