Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve share params bugs and add exclude_layer attr for stage3. #48695

Merged
merged 11 commits into from Jan 10, 2023
Merged

solve share params bugs and add exclude_layer attr for stage3. #48695

merged 11 commits into from Jan 10, 2023

Conversation

wuhuachaocoding
Copy link
Contributor

@wuhuachaocoding wuhuachaocoding commented Dec 4, 2022 •
edited

PR types

New features

PR changes

Others

Describe

this PR solves share params bugs and add exclude_layer attr.
as for exclude_layer attr:

import paddle
from paddle.distributed.sharding import group_sharded_parallel

model = ...
optimizer = ...

# wrap sharding model, optimizer and scaler
# exclude_layer only support sharding stage3
model, optimizer, scaler = group_sharded_parallel(model, optimizer, "p_g_os", scaler=scaler, exclude_layer=["GroupNorm", id(model.gpt.linear)])

@paddle-bot
Copy link

paddle-bot bot commented Dec 4, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wuhuachaocoding wuhuachaocoding changed the title solve share params bugs and add exclude_layer attr. solve share params bugs and add exclude_layer attr for stage3. Dec 4, 2022
haohongxiang
haohongxiang approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@haohongxiang haohongxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ForFishes
ForFishes approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haohongxiang haohongxiang merged commit 79b261b into PaddlePaddle:develop Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@ForFishes ForFishes ForFishes approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@haohongxiang haohongxiang haohongxiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wuhuachaocoding @jzhang533 @ForFishes @XiaoguangHu01 @haohongxiang