Fix several bugs in compile time backward and Protobuf desc #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and Rename `Sync` to `Flush`
Since lots of types can be cast to bool
…oung/Paddle into dev_impl_conv2d_layer
… dev_impl_conv2d_layer
… dev_impl_conv2d_layer
…reyoung/Paddle into fix_backward_bug
… fix_backward_bug
reyoung
reviewed
Oct 18, 2017
paddle/framework/block_desc.cc
Outdated
| @@ -55,6 +55,12 @@ OpDescBind *BlockDescBind::AppendOp() { | |||
| return ops_.back().get(); | |||
| } | |||
|
|
|||
| void BlockDescBind::AppendAllocatedOp(std::unique_ptr<OpDescBind> &op_desc) { | |||
There was a problem hiding this comment.
I think it is pretty hard to figure out the op_desc has been changed inside AppendAllocatedOp for others.
It is better to use std::move outside, and accept the rvalue reference here.
reyoung
reviewed
Oct 18, 2017
paddle/framework/block_desc.cc
Outdated
| void BlockDescBind::AppendAllocatedOp(std::unique_ptr<OpDescBind> &op_desc) { | ||
| need_update_ = true; | ||
| ops_.emplace_back(std::move(op_desc)); | ||
| return; |
reyoung
reviewed
Oct 18, 2017
paddle/framework/block_desc.h
Outdated
| OpDescBind *PrependOp(); | ||
|
|
||
| std::vector<OpDescBind *> AllOps() const; | ||
|
|
||
| int OpSize() const { return ops_.size(); } |
reyoung
reviewed
Oct 18, 2017
paddle/framework/block_desc.h
Outdated
| OpDescBind *PrependOp(); | ||
|
|
||
| std::vector<OpDescBind *> AllOps() const; | ||
|
|
||
| int OpSize() const { return ops_.size(); } | ||
|
|
||
| OpDescBind *Op(int idx) const { return ops_.at(idx).get(); } |
There was a problem hiding this comment.
use size_t as idx, also maybe do not mark this method as const since it will change the program.
reyoung
reviewed
Oct 18, 2017
paddle/pybind/protobuf.cc
Outdated
| @@ -176,8 +176,10 @@ void BindBlockDesc(py::module &m) { | |||
| py::return_value_policy::reference) | |||
| .def("all_vars", &BlockDescBind::AllVars, | |||
| py::return_value_policy::reference) | |||
| .def("all_ops", &BlockDescBind::AllOps, | |||
| py::return_value_policy::reference) | |||
| // .def("all_ops", &BlockDescBind::AllOps, | |||
reyoung
reviewed
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4893
This PR is branched from #4868, so some changed may belong to that one and have no relationship with this topic.