Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glog as dependencies of ops #4908

Merged
merged 3 commits into from
Oct 19, 2017
Merged

Add glog as dependencies of ops #4908

merged 3 commits into from
Oct 19, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 18, 2017 •
edited

  • Use VLOG to logging some information is helpful when we debug Paddle

Fix #4907

@reyoung
Add glog as dependencies of ops
20e1297 
* Use VLOG to logging some information is helpful when we debug Paddle
jacquesqiao
jacquesqiao previously approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JiayiFeng
JiayiFeng approved these changes Oct 19, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@JiayiFeng JiayiFeng merged commit e9249d1 into PaddlePaddle:develop Oct 19, 2017
@reyoung reyoung deleted the feature/add_glog_in_operator branch October 28, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

@jacquesqiao jacquesqiao jacquesqiao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reyoung @jacquesqiao @JiayiFeng