Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Executor RNN support #4910

Closed
wants to merge 51 commits into from
Closed

[WIP] Executor RNN support #4910

wants to merge 51 commits into from

Conversation

tonyyang-svail
Copy link

@tonyyang-svail tonyyang-svail commented Oct 18, 2017 •
edited

Overview

Executor

  1. Instantiate all the ops in the RNN block
  2. Set ops and vars in RNNOp

RNN

  1. Replace NetOp to vector<Op>. This will results compilation failure in backward.cc
  2. Add vector<string> vars_ to represent temporary variable name inside RNN

Checklist:

  • Pass Forward
  • Pass Backward
  • Clean up

@tonyyang-svail tonyyang-svail changed the title Executor RNN support [WIP] Executor RNN support Oct 19, 2017
Yang Yang and others added 28 commits October 24, 2017 23:11
Merge remote-tracking branch 'pr/5057' into executor_rnn
7f5a36b
@reyoung
Partial complete rnn
c46297d
Merge pull request #2 from reyoung/rnn_exec
8a0e4e6 
Partial complete rnn
switch from fill_constant to fill_constant_batch_size_like
9a1427d
Merge remote-tracking branch 'pr/4910' into executor_rnn
9fe3c0f
before merge
3845d6d
Merge remote-tracking branch 'upstream/develop' into executor_rnn
8a45492
Merge remote-tracking branch 'upstream/develop' into executor_rnn
e8d8528
rnn pass simple
019f604
pass rnn forward
1c8c568
fix test_rnn_helpers
4d4029a
clean up
bf5e534
Merge remote-tracking branch 'upstream/develop' into executor_rnn
9f6a292
test_recurrent_op add get_numerical_gradient
a6c34a5
@reyoung
Make InferShape as a field in OpInfo
59d2ae7 
* Op developer can add `InferShape` to any operator
add rnn grad infershape
cb9d119
clean up
830bb21
merge develop
2f69947
before merge develop
d897e45
merge develop
99781eb
push for review
88e1afe
pass backward compile time infershape
0483373
add step_scope; may not be necesarry
bfbcae2
change from Tensor to LoDTensor
72e2490
use LoDTensor by default
ed53e17
add mean to make backward fill op work
acb93f0
op grad can't pass compile
3c7cef4
add grad maker; pass compile
7fe76be
@tonyyang-svail
Copy link
Author

This has been done at #5224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superjomn Superjomn Awaiting requested review from Superjomn

@reyoung reyoung Awaiting requested review from reyoung

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

@QiJune QiJune Awaiting requested review from QiJune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonyyang-svail @reyoung