Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dy2St] 移除 declarative 接口 #49145

Merged
merged 2 commits into from
Dec 19, 2022
Merged

[Dy2St] 移除 declarative 接口 #49145

merged 2 commits into from
Dec 19, 2022

Conversation

Tomoko-hjf
Copy link
Contributor

@Tomoko-hjf Tomoko-hjf commented Dec 18, 2022 •
edited by SigureMo

PR types

Others

PR changes

Others

Describe

Remove declarative API

@paddle-bot
Copy link

paddle-bot bot commented Dec 18, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Dec 18, 2022
@SigureMo SigureMo changed the title 移除 declarative 接口 [Dy2St] 移除 declarative 接口 Dec 18, 2022
@SigureMo SigureMo mentioned this pull request Dec 18, 2022
Closed
SigureMo
SigureMo reviewed Dec 18, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此外有俩单测里被局部 to_static 变量覆盖掉了（CI 里能看到那俩报错了），处理方式和之前那个一样即可～

python/paddle/fluid/tests/unittests/dygraph_to_static/test_declarative.py Outdated Show resolved Hide resolved
Aurelius84
Aurelius84 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ligoml
Ligoml approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

XiaoguangHu01
XiaoguangHu01 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit fa0f693 into PaddlePaddle:develop Dec 19, 2022
@Tomoko-hjf Tomoko-hjf deleted the remove-declarative branch January 1, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo left review comments

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@0x45f 0x45f 0x45f approved these changes

@Ligoml Ligoml Ligoml approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees

@Aurelius84 Aurelius84

@0x45f 0x45f

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Tomoko-hjf @Aurelius84 @0x45f @SigureMo @Ligoml @XiaoguangHu01