Make LoDTensor::lod_element return start and end offset of sequence #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
reviewed
Oct 19, 2017
paddle/framework/lod_tensor.h
Outdated
| @@ -78,7 +78,7 @@ class LoDTensor : public Tensor { | |||
| */ | |||
| size_t lod_element(size_t level, size_t elem) const { | |||
| PADDLE_ENFORCE_LT(level, NumLevels()); | |||
| PADDLE_ENFORCE_LT(elem, NumElements(level)); | |||
| PADDLE_ENFORCE_LE(elem, NumElements(level)); | |||
There was a problem hiding this comment.
貌似应该是 LT
比如某个 level 为 [0 1 2 3 4 5]
NumElements为 5- 可以取的 elem 范围为
0, 1, 2, 3, 4，从0开始
There was a problem hiding this comment.
我看lod_element的实现，是取每个element的start position，我希望能取到end position。如果要取最后一个element的end position, 我就需要level的最后一个值。
现在lod是存储的elem start吧？#3746 (comment)
There was a problem hiding this comment.
0-th level | |
1-th level | | | | |
2-th level | | | | | | | | | |
NumElements(0, 0) get 2 but i hope 4
NumElements(0, 1) get 3 but i hope 6
There was a problem hiding this comment.
或者我们添加一个方法LoDTensor::sizeof(level, elem) ?
There was a problem hiding this comment.
getLength() ? 或者类似跟长度相关的
操作单位是 sequence
Superjomn
approved these changes
Oct 19, 2017
wanghaoshuang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4917