Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto Parallel] Merge dist attrs from python into c++ #49214

Merged
merged 26 commits into from Jan 6, 2023
Merged

[Auto Parallel] Merge dist attrs from python into c++ #49214

merged 26 commits into from Jan 6, 2023

Conversation

aoyulong
Copy link
Contributor

@aoyulong aoyulong commented Dec 21, 2022 •
edited

PR types

Others

PR changes

Others

Describe

This pr merges TensorDistAttr and OperatorDistAttr from python into c++ and delete the python's impls of these dist attrs, which has the follow advantages：

  • Unify the python and c++ dist attr impls
  • Make the interaction with other framework modules easier such as executor.
  • Prepare the necessary preconditions for removing some hacking impls.

aoyulong and others added 15 commits October 31, 2022 11:49
@aoyulong
[Auto Parallel] Rename methods of ProcessMesh
0ce3633
@aoyulong
[Auto Parallel] Impl the python process_mesh by the c++ one
483507f
@aoyulong
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
5f76c6f 
… improve_dist_attr
@aoyulong
[Auto Parallel] Add some minor modifications
9073cb3
@aoyulong
[Auto Parallel] Rename some methods
402533f
@aoyulong
[Auto Parallel] Remove unnecessary codes
6877485
@aoyulong
[Auto Parallel] Add back some removed files
fead1ae
@aoyulong
[Auto Parallel] Fix bugs
9cb5d04
@aoyulong
[Auto Parallel] Fix a bug
87a156a
@aoyulong
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
a986b51 
… improve_dist_attr
@aoyulong
Merge branch 'develop' into improve_dist_attr
9c86a85
@aoyulong
Update process_mesh.cc
a44fba7
@aoyulong
Merge branch 'improve_dist_attr' of https://github.com/aoyulong/Paddle …
7be7165 
…into improve_dist_attr
@aoyulong
[Auto Parallel] Merge dist attrs of Python into C++
1271fbc
@aoyulong
[Auto Parallel] Add back deleted importing
2deb245
@paddle-bot
Copy link

paddle-bot bot commented Dec 21, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

JiabinYang
JiabinYang previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aoyulong aoyulong merged commit c789907 into PaddlePaddle:develop Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@JiabinYang JiabinYang JiabinYang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aoyulong @JiabinYang @wanghuancoder @XiaoguangHu01