Feature/py executor test #4922
Merged
Feature/py executor test #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and Rename `Sync` to `Flush`
Since lots of types can be cast to bool
…oung/Paddle into dev_impl_conv2d_layer
1. It is no need to make global scope thread-safe, since it will be invoked in Python main thread. 2. Do not free the global scope when C++ exit. Let the OS free memories, otherwise, we need to handle the destroy dependencies. See https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
… dev_impl_conv2d_layer
… dev_impl_conv2d_layer
* Use VLOG to logging some information is helpful when we debug Paddle
| b_np = numpy.random.random((784, 100)).astype('float32') | ||
| tensor_b = core.LoDTensor() | ||
| tensor_b.set(b_np, place) | ||
| # del input_tensor |
| @@ -256,7 +256,8 @@ def __init__(self, | |||
| self.desc.set_block_attr(attr_name, attrs[attr_name].desc) | |||
|
|
|||
| self.desc.check_attrs() | |||
| self.desc.infer_shape(self.block.desc) | |||
| if type not in {'feed', 'fetch'}: | |||
| self.desc.infer_shape(self.block.desc) | |||
There was a problem hiding this comment.
why can't we infer shape a feed/fetch?
There was a problem hiding this comment.
InferVarType is also needed.
self.desc.infer_var_type(self.block.desc)
There was a problem hiding this comment.
here infer_shape is a compile-time method. Feed/Fetch op is a run-time operator, do not need to infer shape.
There was a problem hiding this comment.
InferVarType is also needed.
Add in following PRs
QiJune
reviewed
Oct 19, 2017
| 'b': tensor_b}, | ||
| fetch_list=[out])) | ||
| out = numpy.array(outs[0]) | ||
| self.assertEqual((100, 100), out.shape) |
There was a problem hiding this comment.
Better to check the result
self.assertTrue(numpy.allclose(out, numpy.dot(a_np, b_np)))
| @@ -256,7 +256,8 @@ def __init__(self, | |||
| self.desc.set_block_attr(attr_name, attrs[attr_name].desc) | |||
|
|
|||
| self.desc.check_attrs() | |||
| self.desc.infer_shape(self.block.desc) | |||
| if type not in {'feed', 'fetch'}: | |||
| self.desc.infer_shape(self.block.desc) | |||
There was a problem hiding this comment.
InferVarType is also needed.
self.desc.infer_var_type(self.block.desc)
QiJune
reviewed
Oct 19, 2017
paddle/operators/fetch_op.cc
Outdated
| AddInput("X", "The input of fetch op"); | ||
| AddOutput("Out", "The output of fetch op"); | ||
| AddComment("fetch op, it should not be configured by users directly"); | ||
| AddAttr<int>("col", "column of feed"); |
There was a problem hiding this comment.
column of feed --> column of fetch
JiayiFeng
reviewed
Oct 19, 2017
| feed_var_name='feed', | ||
| fetch_var_name='fetch'): | ||
| if not isinstance(program, Program): | ||
| raise TypeError() |
JiayiFeng
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4902