lerp support 0 Tensor #49667
Merged
lerp support 0 Tensor #49667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Jan 10, 2023
| @@ -966,6 +966,20 @@ def test_argsort(self): | |||
| self.assertEqual(x1.grad.numpy(), 0) | |||
| self.assertEqual(x2.grad.numpy(), 0) | |||
|
|
|||
| def test_lerp(self): | |||
There was a problem hiding this comment.
这个API目前支持广播吗？如果支持的话就需要有0D+0D，0D+ND，ND+0D三种case
zhwesky2010
reviewed
Jan 11, 2023
| @@ -101,12 +127,20 @@ void LerpGradKernel(const Context& ctx, | |||
| DenseTensor* x_grad, | |||
| DenseTensor* y_grad) { | |||
| int rank = out.dims().size(); | |||
| PADDLE_ENFORCE_EQ( | |||
There was a problem hiding this comment.
这两个判断反向shape的判读是不是可以不加？不然静态图创建反向目前可能有问题
| y2.stop_gradient = False | ||
| out2 = paddle.lerp(x2, y2, w2) | ||
|
|
||
| prog = paddle.static.default_main_program() |
There was a problem hiding this comment.
需要加paddle.static.append_backward，现在上面的判断跑反向应该会报错。.grad的shape现在会是[1]
zhwesky2010
reviewed
Jan 12, 2023
|
|
||
| prog = paddle.static.default_main_program() | ||
| res = self.exe.run(prog, fetch_list=[out0, out1, out2]) | ||
| self.assertEqual(res[0].shape, ()) |
There was a problem hiding this comment.
这个我试了下可以这么写，paddle.static.append_backward(out0.sum()) 前面out、x的梯度shape就都是正常的了，像动态图一样加下反向shape的测试吧
There was a problem hiding this comment.
done,thanks.
yjjiang11
pushed a commit
to yjjiang11/Paddle
that referenced
this pull request
Jan 13, 2023
* lerp support 0 Tensor * fix lerp grad * fix lerp zero test * fix 0D + ND/ND + 0D * fix check * update code * fix lerp infer shape * static backward test * updata static graph test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Support input 0D Tensor for Lerp