Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding interface for the adagrad optimizer #4977

Merged
merged 2 commits into from
Oct 21, 2017
Merged

Adding interface for the adagrad optimizer #4977

merged 2 commits into from
Oct 21, 2017

Conversation

kexinzhao
Copy link
Contributor

fixes #4916

abhinavarora
abhinavarora suggested changes Oct 20, 2017
View reviewed changes
python/paddle/v2/framework/optimizer.py Outdated
"""
_moment_acc_str = "moment"

def __init__(self, learning_rate, epsilon):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can give a default value to the epsilon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if the original paper mentions a default learning rate value for the Adagrad optimizer, then you can add it too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The original paper does not specify a default learning rate. Only added default value to epsilon.

abhinavarora
abhinavarora approved these changes Oct 21, 2017
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. The PR looks great.

@kexinzhao kexinzhao merged commit 5fd4bee into PaddlePaddle:develop Oct 21, 2017
@kexinzhao kexinzhao deleted the python_adagrad branch October 21, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavarora abhinavarora abhinavarora approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write Adagrad Op Python Wrapper
2 participants
@kexinzhao @abhinavarora