kunlun support c_softmax_with_cross_entropy #49934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
XiaociZhang
force-pushed
the
collective
branch
from
b5c27c9
to
b8b43a2
Compare
XiaociZhang
force-pushed
the
collective
branch
from
b8b43a2
to
ac3e624
Compare
chenwhql
reviewed
Feb 17, 2023
| ) | ||
|
|
||
| import paddle | ||
| import paddle.fluid as fluid |
There was a problem hiding this comment.
fluid代码正在全局清理，建议别再使用fluid了，data program这些在paddle.static下有
| @@ -0,0 +1,148 @@ | |||
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
chenwhql
previously approved these changes
Feb 20, 2023
| @@ -0,0 +1,509 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
QingshuChen
reviewed
Feb 20, 2023
| } | ||
|
|
||
| std::vector<phi::DenseTensor> in_out; | ||
| in_out.push_back(logits_max); |
There was a problem hiding this comment.
all reduce前需要xpu_wait吗？
There was a problem hiding this comment.
重新看了一下代码，不需要加，这个老版本的AllReduce本身会sync计算流
|
|
||
| in_out.clear(); | ||
| in_out.push_back(predicted_logits); | ||
| opts.reduce_op = distributed::ReduceOp::SUM; |
chenwhql
approved these changes
Feb 23, 2023
QingshuChen
approved these changes
Feb 23, 2023
|
你的PR已合入Paddle库，请关注后续测试结果。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
add support for c_softmax_with_cross_entropy_xpu