Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Divide by 0 Error] add svd check #49968

Merged
merged 3 commits into from Feb 3, 2023
Merged

[Divide by 0 Error] add svd check #49968

merged 3 commits into from Feb 3, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jan 20, 2023

@paddle-bot
Copy link

paddle-bot bot commented Jan 20, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 20, 2023
@luotao1 luotao1 mentioned this pull request Jan 20, 2023
Closed
wanghuancoder
wanghuancoder reviewed Jan 31, 2023
View reviewed changes
python/paddle/fluid/tests/unittests/test_linalg_svd_op.py Outdated
@@ -0,0 +1,35 @@
# Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测不需要新建文件，放到python/paddle/fluid/tests/unittests/test_svd_op.py即可

python/paddle/tensor/linalg.py Outdated
Comment on lines 1924 to 1927

if x.size == 0:
raise ValueError("input size should not be 0")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

判断放到C++端吧，放在python会影响API性能

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已由 #49951 修复

wanghuancoder
wanghuancoder approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit f2ec69b into PaddlePaddle:develop Feb 3, 2023
@gouzil gouzil deleted the fix-svd-divide-by-0 branch February 28, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gouzil @wanghuancoder @luotao1