Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Prim】 Generate static prim api in both ops.yaml and legacy_ops.yaml #50315

Merged
merged 1 commit into from Feb 12, 2023

Conversation

cxxly
Copy link
Contributor

@cxxly cxxly commented Feb 8, 2023

PR types

New features

PR changes

Others

Describe

  • support both ops.yaml and legacy_ops.yaml generated.
  • auto generated higher priority prim api.

@paddle-bot
Copy link

paddle-bot bot commented Feb 8, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cxxly cxxly force-pushed the prim_api_generator branch 3 times, most recently from f13ef83 to fa8275a Compare February 10, 2023 09:12
@cxxly cxxly changed the title [prim] generate static prim api 【Prim】 Generate static prim api in both ops.yaml and legacy_ops.yaml Feb 10, 2023
Comment on lines 76 to 77
def is_tensor_sequence(s):
return s == 'Tensor[]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前生成脚本中 Tensor[] 主要是以 tensor_list 命名,这里保持一致比较好些

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 5 to 9
if(NOT (NOT WITH_PYTHON AND ON_INFER))
cc_library(eager_prim_api DEPS generated_eager_prim_api manual_eager_prim_api)
endif()
cc_library(static_prim_api DEPS generated_static_prim_api
manual_static_prim_api)

if(NOT (NOT WITH_PYTHON AND ON_INFER))
cc_library(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两处宏判断逻辑可以合并吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,157 @@
# Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022->2023

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Charles-hit Charles-hit merged commit 82cf1fa into PaddlePaddle:develop Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants