Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv phi and fluid/test To test dir #50640

Merged
merged 24 commits into from
Mar 20, 2023
Merged

Mv phi and fluid/test To test dir #50640

merged 24 commits into from
Mar 20, 2023

Conversation

tianshuo78520a
Copy link
Contributor

@tianshuo78520a tianshuo78520a commented Feb 19, 2023

PR types

Others

PR changes

Others

Describe

修改Paddle单测目录,所有单测将放在/Paddle/test目录下
PR先进行phi,和一些Python单测迁移工作。

@paddle-bot
Copy link

paddle-bot bot commented Feb 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@tianshuo78520a tianshuo78520a changed the title mv test Mv phi and fluid/test To test dir Mar 9, 2023
@tianshuo78520a tianshuo78520a changed the title Mv phi and fluid/test To test dir Mv phi and fluid/test To test dir测试 Mar 15, 2023
@tianshuo78520a tianshuo78520a changed the title Mv phi and fluid/test To test dir测试 Mv phi and fluid/test To test dir Mar 15, 2023
CMakeLists.txt Outdated
@@ -699,6 +699,7 @@ if(WITH_STRIP)
endif()

add_subdirectory(paddle)
add_subdirectory(test)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it to the line after python, i.e, line 705

@@ -191,7 +191,7 @@ TEST(GpuLayerTest, Construct) {
TEST(GpuLayerTest, Clone) {
auto place = phi::GPUPlace();

std::string path = "./multi_program_load/export";
std::string path = "../multi_program_load/export";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the absolute path?

CACHE INTERNAL "python tests directory")

add_subdirectory(cpp)
add_subdirectory(old_test)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old_test -> legacy_test?

@@ -1,5 +1,5 @@
set(CC_TESTS_DIR
${PADDLE_BINARY_DIR}/paddle/tests
${PADDLE_BINARY_DIR}/test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redefined in test/CMakeLists.txt

@@ -48,93 +48,3 @@ set(POSTFIX ".so")
if(WIN32)
set(POSTFIX ".dll")
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 40-50 is no need here, and the comments should be moved to test/CMakeLists.txt

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit e808fa3 into PaddlePaddle:develop Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants