-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mv phi and fluid/test To test dir #50640
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
CMakeLists.txt
Outdated
@@ -699,6 +699,7 @@ if(WITH_STRIP) | |||
endif() | |||
|
|||
add_subdirectory(paddle) | |||
add_subdirectory(test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move it to the line after python, i.e, line 705
paddle/fluid/jit/layer_test.cc
Outdated
@@ -191,7 +191,7 @@ TEST(GpuLayerTest, Construct) { | |||
TEST(GpuLayerTest, Clone) { | |||
auto place = phi::GPUPlace(); | |||
|
|||
std::string path = "./multi_program_load/export"; | |||
std::string path = "../multi_program_load/export"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the absolute path?
test/CMakeLists.txt
Outdated
CACHE INTERNAL "python tests directory") | ||
|
||
add_subdirectory(cpp) | ||
add_subdirectory(old_test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old_test -> legacy_test?
paddle/CMakeLists.txt
Outdated
@@ -1,5 +1,5 @@ | |||
set(CC_TESTS_DIR | |||
${PADDLE_BINARY_DIR}/paddle/tests | |||
${PADDLE_BINARY_DIR}/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redefined in test/CMakeLists.txt
paddle/CMakeLists.txt
Outdated
@@ -48,93 +48,3 @@ set(POSTFIX ".so") | |||
if(WIN32) | |||
set(POSTFIX ".dll") | |||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 40-50 is no need here, and the comments should be moved to test/CMakeLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
修改Paddle单测目录,所有单测将放在/Paddle/test目录下
PR先进行phi,和一些Python单测迁移工作。