Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.89】 Remove circle import Part1 #50677

Merged
merged 3 commits into from
Mar 8, 2023
Merged

【Hackathon No.89】 Remove circle import Part1 #50677

merged 3 commits into from
Mar 8, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Feb 20, 2023 •
edited

PR types

Others

PR changes

Others

Describe

Details

@paddle-bot
Copy link

paddle-bot bot commented Feb 20, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 20, 2023
@2742195759
Copy link
Contributor

同学我是这个PR的reviewer，我看你的PR什么都没有修改。是修改撤回了吗？

@Liyulingyue
Copy link
Contributor Author

Liyulingyue commented Feb 27, 2023 •
edited

同学我是这个PR的reviewer，我看你的PR什么都没有修改。是修改撤回了吗？

你好~ 我的本地文件有点太混乱了，所以rollback了一下，整理完后会重新推上来提交~

@Liyulingyue Liyulingyue changed the title 【Hackathon No.89】 Remove circle import 测试用，请勿review Mar 2, 2023
@Liyulingyue Liyulingyue changed the title 测试用，请勿review 【Hackathon No.89】 Remove circle import Part1 Mar 3, 2023
@Liyulingyue
Copy link
Contributor Author

Liyulingyue commented Mar 4, 2023 •
edited

@2742195759 您好，很抱歉这个任务拖到了现在才开始着手解决。

rfc已经提交了，链接为 PaddlePaddle/community#409

Aurelius84
Aurelius84 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 4784673 into PaddlePaddle:develop Mar 8, 2023
@Liyulingyue Liyulingyue deleted the circle_import_1 branch March 23, 2023 11:05
@Ligoml Ligoml mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

Assignees

@luotao1 luotao1

@Aurelius84 Aurelius84

@2742195759 2742195759

@Ligoml Ligoml

@cloud2009 cloud2009

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Liyulingyue @2742195759 @Aurelius84 @luotao1 @Ligoml @cloud2009