add test_Expand and simply the gserver/tests/CMakeLists #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddle/gserver/tests/test_Expand.cpp
Outdated
| // CPU case 2. non-seq expand to sub-seq | ||
| // input1 = 1,2,3 | ||
| // input2 = [[4,5]],[[6]],[[7],[8,9]] | ||
| // result = [[1,1]],[[2]],[[3],[3,3]] |
There was a problem hiding this comment.
如果input1 = 1,2,3,4
result应该等于多少？
There was a problem hiding this comment.
你怎么check input1和input2是合法的？
input1.batch_size == len(input2.seq)
还是
input1.batch_size == len(input2.sub_seq)
你去确定input1 = 1,2,3,4 和 input1 = 1,2,3 都可以过这个check么？
There was a problem hiding this comment.
input1.batch_size == len(input2.seq)，0维到2维的时候，目前的代码按照sequence level进行expand。所以1,2,3,4这个输入是不合法的。
| // CPU case 3. seq expand to sub-seq | ||
| // input1 = [1,2],[3],[4] | ||
| // input2 = [[4,5]],[[6]],[[7],[8,9]] | ||
| // result = [[1,1]],[[2]],[[3],[4,4]] |
There was a problem hiding this comment.
如果input1 = [1,2],[3]
result应该等于什么？[[1,1]],[[2]],[[3],[3,3]]？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5013