Add expand composite rule #50810
Add expand composite rule #50810
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
… composite_rule_expand
| shape_in = x.shape | ||
| assert len(shape) >= len(shape_in) | ||
| dim_out = len(shape) | ||
| dim_in = len(shape_in) |
| dim_out = len(shape) | ||
| dim_in = len(shape_in) | ||
| if dim_out == 0: | ||
| return x |
There was a problem hiding this comment.
test case does not cover this branch, add relative case
There was a problem hiding this comment.
dim_out can't be 0, remove the code.
|
|
||
|
|
||
| # Situation 10: comp case, input x is Bool | ||
| class TestExpandV2CompOpBoolean(OpTest): |
There was a problem hiding this comment.
之前没有组合测试的单测可以去掉，例如Shape Tensor类的
| for i in range(dim_out - dim_in): | ||
| shape_in_expand.append(1) | ||
| shape_in_expand.extend(shape_in) | ||
| x_reshape = reshape(x, shape_in_expand) |
There was a problem hiding this comment.
Add comment to show why we need reshape first
There was a problem hiding this comment.
Under the static graph, the tile op will set the expanded dimension to -1 when expanding the tensor, which will result in failure to pass the shape check. So for tensors that need to expand the dimension, reshape will be used in advance
There was a problem hiding this comment.
PR types
Others
PR changes
Others
Describe
add composite rule for expand