【Hackathon No.68】Remove utils in phi #50833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove utils
# Conflicts: # paddle/fluid/operators/unsqueeze_op.h # paddle/fluid/operators/utils.h
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
reviewed
Feb 24, 2023
| @@ -144,4 +148,36 @@ inline T GetValue(const Context& dev_ctx, const DenseTensor& x) { | |||
| return value; | |||
| } | |||
|
|
|||
| template <typename T = int32_t> | |||
| inline std::vector<T> GetVectorFromTensor(const phi::DenseTensor* x) { | |||
There was a problem hiding this comment.
迁移过来后，需要把原位置的代码进行删除
删除了~
PR-CI-OP-benchmark过不去应该与这个pr的改动无关，我尝试过仅将paddle/fluid/operators/unsqueeze_op.h的中的变量need_resize_out_dims重命名为need_dims，无法通过该ci。
YuanRisheng
approved these changes
Feb 27, 2023
This was referenced Feb 27, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
paddle::framework::TensorCopySync参考[PHI decoupling]decouple tensor_utils of TensorCopy #50264