Correcting grammatical mistakes in model format design doc #5087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Oct 25, 2017
| @@ -33,4 +33,6 @@ In detail, tensor's byte view as the table shows. Note that all the signed valu | |||
|
|
|||
| ## Summary | |||
|
|
|||
| We introduce the model format, the `ProgramDesc` describe the **topology**, and a bunch of particular format binary tensors describes the **parameters**. | |||
| - We introduce a model format. | |||
| - The `ProgramDesc` describe the model **topology**. | |||
There was a problem hiding this comment.
I think ProgramDesc is not for describing the model, but the computation procedure. Here we are using the fact that a DL model can be represented by the forward-pass, so could we represent the model by a ProgramDesc containing the forward-pass. So we might want to replace
The
ProgramDescdescribe the model topology
into
The model represented by its forward-pass computation procedure saved in a
ProgramDescprotobuf message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.