【Hackathon No.67】remove operator.h in blas.h #50989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
jinyouzhi
changed the title
|
@YuanRisheng @luotao1 @Ligoml Could you give some comments? |
YuanRisheng
approved these changes
Mar 9, 2023
|
@XiaoguangHu01 We need a special approval for >=20 files changes. Could you help review? thanks |
YuanRisheng
added a commit
to YuanRisheng/Paddle
that referenced
this pull request
Mar 10, 2023
)" This reverts commit 3f4917f.
YuanRisheng
added a commit
that referenced
this pull request
Mar 10, 2023
|
该PR合入后造成CI编译失败，或许是产生了隐形代码冲突导致，目前已经revert。请使用最新代码进行调试并重新提交该PR @jinyouzhi |
好的辛苦了，我正在看 |
jinyouzhi
added a commit
to jinyouzhi/Paddle
that referenced
this pull request
Mar 13, 2023
…addle#50989)" (PaddlePaddle#51467)" This reverts commit b9d9153.
YuanRisheng
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Revert "Revert "【Hackathon No.67】remove operator.h in blas.h (#50989)" (#51467)" This reverts commit b9d9153. * remove cout * add header * fix missing header * fix refer fluid error * fix missing header * 更新 repeat_interleave_grad_kernel_impl.h Change to phi style datatype. * 更新 repeat_interleave_grad_kernel_impl.h Fix missing header * datatype fluid -> phi * paddle::experimental -> phi * fix reference error * fix reference error * fix reference error * fix errors * fix missing FLAGS * fix missing headers * fix missing headers * fix missing headers * fix missing headers * fix missing header * fix missing header * fix errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
aim to remove the
paddle/fluid/framework/operator.hin phi