[AMP OP&Test] add bf16 fp16 type support for interpolate #51153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lanxianghit
approved these changes
Mar 6, 2023
|
经开发者沟通，之前的这个Op有对应的uint8和int64前向，没有对应的反向，会报缺少某些数据类型的错。但本PR修改的是fp16和bf16，和相关注册类型没有关系。uint8和int64可能为了推理所加。 故本PR中，我approve和数据类型注册相关CI |
zhhsplendid
approved these changes
Mar 6, 2023
ZzSean
changed the title
ZzSean
reviewed
Mar 6, 2023
| @@ -105,13 +110,14 @@ static void BilinearInterpolationGrad(const DenseTensor& output_grad, | |||
| for (int j = 0; j < c; j++) { // loop for channels | |||
| // bilinear interpolation grad | |||
| if (data_layout == DataLayout::kNCHW) { | |||
| const T grad = output_grad_t(i, j, k, l); | |||
| // const T grad = output_grad_t(i, j, k, l); | |||
There was a problem hiding this comment.
done
对应PR#51660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
add fp16 and bf16 support for interpolate in phi