Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Prim】Support erf fp64 error #51241

Merged
merged 1 commit into from Mar 7, 2023
Merged

【Prim】Support erf fp64 error #51241

merged 1 commit into from Mar 7, 2023

Conversation

JiabinYang
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

This PR fix composite full api on fp64 error

@paddle-bot
Copy link

paddle-bot bot commented Mar 6, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

GGBond8488
GGBond8488 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@GGBond8488 GGBond8488 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaoguoguo626807
xiaoguoguo626807 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full can't support fp16?

@JiabinYang
Copy link
Contributor Author

full can't support fp16?

Not really, we use str_value in full, so it can still be used in fp16

@JiabinYang JiabinYang merged commit db82b9e into PaddlePaddle:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GGBond8488 GGBond8488 GGBond8488 approved these changes

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JiabinYang @GGBond8488 @xiaoguoguo626807