【Hackathon 4th No.30】为 Paddle 新增 paddle.sparse.sum 稀疏 API #51406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
This was referenced Mar 9, 2023
zrr1999
force-pushed
the
sparse_sum
branch
2 times, most recently
from
dabe353
to
d2d9baa
Compare
zkh2016
previously approved these changes
Apr 27, 2023
umiswing
previously approved these changes
Apr 27, 2023
luotao1
reviewed
Apr 28, 2023
| @@ -35,6 +35,7 @@ | |||
| from .unary import rad2deg | |||
| from .unary import expm1 | |||
| from .unary import transpose | |||
| from .unary import sum | |||
| from .unary import reshape | |||
| from .unary import isnan | |||
There was a problem hiding this comment.
__all__里面加上sum，否则文档不会暴露在官网
__all__ = [
'sparse_coo_tensor',
...
]
There was a problem hiding this comment.
好的，已添加
PaddlePaddle/docs#5846
|
@luotao1 麻烦帮忙看下这个ci时怎么回事，重试了好几次依然还是错误，也重新push了几次把develop最新的内容也合入了。civerage是正常的，只有build那几个一直失败 |
|
你可以贴一下build成功/失败的diff，目前CI develop的build是正常的，所以需要看下diff是什么，修改了哪些代码，commit太多了，看不出来。 |
|
|
python/paddle/sparse/unary.py
Outdated
|
|
||
| Returns: | ||
| Tensor: Results of summation operation on the specified axis of input Tensor `x`, | ||
| if `x.dtype='bool'`, `x.dtype='int32'`, it's data type is `'int64'`, |
There was a problem hiding this comment.
建议改成
- if
x.dtype='bool'orx.dtype='int32'，否则容易造成误解。 - 上一句的末尾改成句号吧
|
|
好的，已修改 |
luotao1
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
Add paddle.sparse.sum
document pr: PaddlePaddle/docs#5846
rfc pr: PaddlePaddle/community#411
特殊说明
对于coo格式的稀疏张量，即使keep_dim为False，得到的结果张量的sparse_dim以及dense_dims.size()也会不小于1。
即当x.shape=[5,5],x.sparse_dim=1时，keep_dim=False
y=sum(x, axis=0)
z=sum(x, axis=1)
得到
y.shape=[1,5],y.sparse_dim=1
z.shape=[5,1],z.sparse_dim=1