Add dilation for exconv layer #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedaoyuan
reviewed
Nov 13, 2017
paddle/function/ConvOpTest.h
Outdated
| batchSize > 1 && stride > 1) | ||
| break; | ||
| if ((conv1 == "NaiveConv-CPU" || conv2 == "NaiveConv-CPU") && | ||
| dilation > 1) |
There was a problem hiding this comment.
The NNPACKConv also does not support dilation.
| @@ -79,45 +79,54 @@ void Convolution(const std::string& conv1, | |||
| if (outputChannels < inputChannels) continue; | |||
| for (size_t stride : {1, 2}) { | |||
| for (size_t padding : {0, 1}) { | |||
| if (padding >= filterSize) break; | |||
| for (size_t dilation : {1, 3}) { | |||
| if (padding >= filterSize) break; | |||
There was a problem hiding this comment.
Why here do not need some checking like in the 'Im2ColTest.cpp? filterSizemultiplied bydilationmay be greater thaninputSize`.
size_t filterSizeH = (filterHeight - 1) * dilation + 1;
size_t filterSizeW = (filterWidth - 1) * dilation + 1;
if (inputHeight <= filterSizeH || inputWidth <= filterSizeW)
break;
if (padding >= filterSizeH || padding >= filterSizeW) break;
size_t outputHeight =
(inputHeight - filterSizeH + 2 * padding) / stride + 1;
size_t outputWidth =
(inputWidth - filterSizeW + 2 * padding) / stride + 1;
There was a problem hiding this comment.
I add the control to it, the inputSize + 2 * padding < filterS.
hedaoyuan
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5164
fix #5242