【Hackathon No.31】 Fix divide zero bug for Case 6:paddle.nn.functional.softmax_with_cross_entropy #51697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
|
|
|
zeroRains
changed the title
说明补充的单测并没有进入 if 条件里面 |
|
|
Comment on lines
+2341
to
+2342
| if 0 in logits.shape: | ||
| raise ValueError("The dims of Input(X) should be greater than 0.") |
There was a problem hiding this comment.
你好，这个判断还是加到C++kernel里吧。原则是：能在C++里加的检查不在python加。否则影响动态图API性能
There was a problem hiding this comment.
额，好像这个不用修了，那我取消PR吧
好的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
#49919(comment)