add pool3dgrad special dim support #51727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QingshuChen
reviewed
Mar 17, 2023
| @@ -197,16 +193,18 @@ struct XPUContext::Impl { | |||
| } | |||
|
|
|||
| void SetXdlCtx(std::string thread_name) { | |||
There was a problem hiding this comment.
thread_name这个参数没有用了？
现在是怎么判断当前线程是不是dataloader的线程？
There was a problem hiding this comment.
已改，线程现在会在每次getcontext的时候判断是否是dataloader，dataloader的context map会以pid为key
There was a problem hiding this comment.
是的，会判断当前线程名字是不是dataloader的
| if (ctx_t) { | ||
| PD_CHECK(ctx_t != nullptr, "the xpu dataloader context is nullptr."); | ||
| xpu_wait(ctx_t->xpu_stream); | ||
| } |
…port, test=kunlun
HarperCy
approved these changes
Mar 20, 2023
houj04
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
substitude max pool3d grad xpu for max pool2d grad api when d=1.
fix previous xpu dataloader context map bug.