【Prim】Support Relu Custom VJP #51742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoguoguo626807
approved these changes
Mar 20, 2023
|
|
||
|
|
||
| class TestCompositeSoftmaxPrimBackward(unittest.TestCase): | ||
| "test composite softmax and prim backward" |
There was a problem hiding this comment.
change softmax as relu
There was a problem hiding this comment.
Done in PR 51838
| @@ -0,0 +1,122 @@ | |||
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
it's better to delete this if op test with prim can cover this test
There was a problem hiding this comment.
Since activation op test only test simple case, add this case can be more safe to use.
| @@ -97,6 +97,7 @@ def composite_batchnorm( | |||
| batch_mean = zeros(run_mean.shape, run_mean.dtype) | |||
| batch_var = zeros(run_var.shape, run_var.dtype) | |||
| if not use_run_stat: | |||
|
|
|||
There was a problem hiding this comment.
unnecessary change
There was a problem hiding this comment.
pre-commit hook did this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Pcard-66975
This PR support relu custom vjp.