No.55 complete argsort FP16 test, add argsort BF16 support and test #51823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superwinner1
changed the title
superwinner1
changed the title
Vvsmile
reviewed
Mar 20, 2023
Vvsmile
reviewed
Mar 20, 2023
Vvsmile
reviewed
Mar 20, 2023
Vvsmile
reviewed
Mar 20, 2023
Vvsmile
reviewed
Mar 20, 2023
Vvsmile
reviewed
Mar 20, 2023
Vvsmile
reviewed
Mar 20, 2023
|
好的，我将按照您的建议进行进一步更改 |
|
继承了OpTest类后，重写setUp()函数里面的self.op_type = "argsort"不对吗，CI测试结果提示我应该修改为self.class.op_type = "argsort" |
Vvsmile
reviewed
May 10, 2023
| or not core.is_bfloat16_supported(core.CUDAPlace(0)), | ||
| "core is not compiled with CUDA and not support the bfloat16", | ||
| ) | ||
| class TestArgsortBF16OP(unittest.TestCase): |
There was a problem hiding this comment.
这个我记得之前实现的时候是OpTest，现在为啥又换成了TestCase，最好继承OpTest，如果有单测问题不好解决可以留言帮忙解决
Vvsmile
reviewed
May 10, 2023
Vvsmile
reviewed
May 10, 2023
|
Sorry to inform you that 0fec5d6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
你好，这个PR已经几乎接近完成了，目前看上去有一些代码冲突，可以解决下冲突，如果没有其他问题应该就可以合入了 |
Closed
|
close due to the following PR is merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
complete argsort FP16 test, add argsort BF16 support and test