Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zero-Dim] add FLAGS_set_to_1d, control whether to hack process to 1D #51899

Merged
merged 1 commit into from Mar 27, 2023
Merged

[Zero-Dim] add FLAGS_set_to_1d, control whether to hack process to 1D #51899

merged 1 commit into from Mar 27, 2023

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Mar 21, 2023 •
edited

PR types

Others

PR changes

APIs

Describe

Tensor.numpy() 有一个hack，这个 FLAGS_set_to_1d=False 可以关闭这个hack。将对内CI关闭这个hack，避免掩盖住各种问题，导致随着hack问题积累增多，不利于后期迭代。

  • true：将0D Tensor设置为1D Numpy
  • false：将0D张量正确的保持为0D Numpy

注：同时补充了一些XPU单测

@zhwesky2010 zhwesky2010 force-pushed the FLAGS_set_to_1d branch 3 times, most recently from 99f8a74 to 0a7eaf7 Compare March 21, 2023 09:41
jeff41404
jeff41404 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 134c9c0 into PaddlePaddle:develop Mar 27, 2023
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhwesky2010 @jeff41404