Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Mv] reader to legacy_test #51943

Merged
merged 7 commits into from
Mar 23, 2023
Merged

[Test Mv] reader to legacy_test #51943

merged 7 commits into from
Mar 23, 2023

Conversation

Zheng-Bicheng
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

移动单测目录

@Zheng-Bicheng Zheng-Bicheng mentioned this pull request Mar 21, 2023
Closed
@Zheng-Bicheng
Copy link
Contributor Author

@tianshuo78520a

@Zheng-Bicheng
Copy link
Contributor Author

关联Issues

@paddle-bot paddle-bot bot added the contributor External developers label Mar 21, 2023
@Zheng-Bicheng
Copy link
Contributor Author

对文件名进行了修改,decorator_test改为 test_decorator

@tianshuo78520a
Copy link
Contributor

对文件名进行了修改,decorator_test修改为test_decorator

很好的改动

@Zheng-Bicheng
Copy link
Contributor Author

考虑到set_tests_properties都需要在add_test后执行。后续的单测目录如果每一个CMakeList都包含if(WITH_TESTING)的判断会很麻烦，因此改为在test/CMakeLists.txt中判断if(WITH_TESTING)。

zhiqiu
zhiqiu approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 227245d into PaddlePaddle:develop Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zheng-Bicheng @tianshuo78520a @zhiqiu @luotao1