[Hackathon NO.77] 为 Paddle-TRT 添加 bitwise 算子 #51971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…develop add bitwise_not trt converter.
|
|
|
|
zhangjun
reviewed
Mar 23, 2023
Comment on lines
+38
to
+41
| if (data_type == nvinfer1::DataType::kBOOL) { | ||
| layer = TRT_ENGINE_ADD_LAYER( | ||
| engine_, Unary, *input_tensor, nvinfer1::UnaryOperation::kNOT); | ||
| } else { |
There was a problem hiding this comment.
bool类型支持需要trt 8.4，可以在op_teller中判断过滤。 对应单测可能有细微调整。
There was a problem hiding this comment.
已修改，有劳老师再 review 一下
zhangjun
reviewed
Mar 23, 2023
Comment on lines
28
to
32
| ver = paddle_infer.get_trt_compile_version() | ||
| trt_version = ver[0] * 1000 + ver[1] * 100 + ver[2] * 10 | ||
| if trt_version < 8400: | ||
| if program_config.inputs['input_data'].dtype == bool: | ||
| return False |
There was a problem hiding this comment.
参考其他单测，也可以放在generate_trt_nodes_num中，此处不做限制.
如
zhangjun
reviewed
Mar 24, 2023
Comment on lines
107
to
109
| def generate_trt_nodes_num(attrs, dynamic_shape): | ||
| if self.dims == 1 and not dynamic_shape: | ||
| return 0, 3 |
There was a problem hiding this comment.
这里加和op_teller一样的trt 版本限制，否则单测会无法通过。
is_program_valid处可以去掉
|
hi, @Young-Flash
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
TensorRT 中没有 bitwise 操作的算子，无法直接映射 bitwise_and，TensorRT 中与 bitwise_and 算子接近的是 ElementWiseAnd，但只支持 bool 类型。
这个 PR 中用 TensorRT 已有算子组合出了 bitwise_not，思路如下：
ElementWiseOperation::kPROD和ElementWiseOperation::kSUM组合而成