[Test Mv] move collective/multinode to test dir #51982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
| @@ -5,8 +5,56 @@ set(PYTHON_TESTS_DIR | |||
| ${PADDLE_BINARY_DIR}/test | |||
| CACHE INTERNAL "python tests directory") | |||
|
|
|||
| function(bash_test_modules TARGET_NAME) | |||
There was a problem hiding this comment.
python/paddle/fluid/tests/unittests/CMakeLists.txt 下的bash_test_modules能否进行删除？
There was a problem hiding this comment.
python/paddle/fluid/tests/unittests/CMakeLists.txt 下的bash_test_modules能否进行删除？
因为 python/paddle/fluid/tests/unittests/CMakeLists.txt 中后续也用到 bash_test_modules 函数，如下图：
在 PR-CI-ROCM-Compile 中也会报错：
There was a problem hiding this comment.
OK，可以留到最后删除python/paddle/fluid/tests目录
tianshuo78520a
previously approved these changes
Mar 24, 2023
| @@ -5,8 +5,56 @@ set(PYTHON_TESTS_DIR | |||
| ${PADDLE_BINARY_DIR}/test | |||
| CACHE INTERNAL "python tests directory") | |||
|
|
|||
| function(bash_test_modules TARGET_NAME) | |||
There was a problem hiding this comment.
OK，可以留到最后删除python/paddle/fluid/tests目录
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
move collective/multinode to test dir
#51853