Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Mv] move dygraph_to_static to test dir #52069

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[Test Mv] move dygraph_to_static to test dir #52069

merged 1 commit into from
Mar 31, 2023

Conversation

Ainavo
Copy link
Contributor

@Ainavo Ainavo commented Mar 23, 2023 •
edited

PR types

Others

PR changes

Others

Describe

move dygraph_to_static to test dir

@paddle-bot
Copy link

paddle-bot bot commented Mar 23, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 23, 2023
This was referenced Mar 23, 2023
Closed
Closed
@Ainavo Ainavo force-pushed the move_test_dygraph_to_static branch from a11082d to 9cdb91f Compare March 26, 2023 17:03
@SigureMo SigureMo mentioned this pull request Mar 29, 2023
Merged
@tianshuo78520a
Copy link
Contributor

tianshuo78520a commented Mar 29, 2023 •
edited

在python/paddle/fluid/tests/unittests/CMakeLists.txt文件中，删除test_cast，test_slice，并使用pre-commit进行代码更新。
image

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 29, 2023

在python/paddle/fluid/tests/unittests/CMakeLists.txt文件中，删除test_cast，test_slice，并使用pre-commit进行代码更新。 image

image
python/paddle/fluid/tests/unittests/CMakeLists.txt文件下好像没有test_cast，test_slice，只有 test_slice_op 和 test_cast_op。

@tianshuo78520a
Copy link
Contributor

Details

嗯嗯，刚刚看错了，可以忽略。麻烦看下这个问题，本地使用pip install pre-commit==2.17.0,pre-commit install再提交代码。
image

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 29, 2023

Details

嗯嗯，刚刚看错了，可以忽略。麻烦看下这个问题，本地使用pip install pre-commit==2.17.0,pre-commit install再提交代码。 image

好的

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 29, 2023

@tianshuo78520a 这里尝试复现 CINN 流水线中的错误，在 test_slice 中增加了一行注释也会报错相同的错误，如下图
image
测试 pr：

另外 #52060 中也遇到了相同的情况，貌似对 test_slice 文件进行改动就会复现相同的错误。

@Ainavo Ainavo mentioned this pull request Mar 29, 2023
Closed
@tianshuo78520a
Copy link
Contributor

@tianshuo78520a 这里尝试复现 CINN 流水线中的错误，在 test_slice 中增加了一行注释也会报错相同的错误，如下图 image 测试 pr：

另外 #52060 中也遇到了相同的情况，貌似对 test_slice 文件进行改动就会复现相同的错误。

正在找相关同学排查，发现问题后再回复您

@luotao1
Copy link
Contributor

luotao1 commented Mar 30, 2023

CINN流水线脚本问题，已修复，可以解决下冲突重新跑CI

@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 30, 2023

CINN流水线脚本问题，已修复，可以解决下冲突重新跑CI

收到

@Ainavo Ainavo force-pushed the move_test_dygraph_to_static branch from 6d6dda2 to b5308c0 Compare March 30, 2023 16:51
@Ainavo Ainavo force-pushed the move_test_dygraph_to_static branch from b5308c0 to 3a876f7 Compare March 31, 2023 02:55
@Ainavo
Copy link
Contributor Author

Ainavo commented Mar 31, 2023

辛苦@tianshuo78520a review一下~

tianshuo78520a
tianshuo78520a approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@tianshuo78520a tianshuo78520a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 404162b into PaddlePaddle:develop Mar 31, 2023
@SigureMo SigureMo deleted the move_test_dygraph_to_static branch March 31, 2023 07:57
@Ainavo Ainavo restored the move_test_dygraph_to_static branch March 31, 2023 09:18
@Ainavo Ainavo deleted the move_test_dygraph_to_static branch March 31, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ainavo @tianshuo78520a @luotao1 @zhiqiu