Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move Test] move rpc #52166

Merged
merged 5 commits into from
Mar 28, 2023
Merged

[Move Test] move rpc #52166

merged 5 commits into from
Mar 28, 2023

Conversation

Zheng-Bicheng
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

移动rpc文件夹

@paddle-bot
Copy link

paddle-bot bot commented Mar 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Zheng-Bicheng
Copy link
Contributor Author

特殊改动介绍

原先判断是否进行rpc test的逻辑为先判断是否WITH_RPC然后add_subdirectory(rpc)。为了保证其他pr不需要频繁merge,把add_subdirectory操作提前,不论是否WITH_RPCadd_subdirectory(rpc),但是rpc目录下的CMakeLists文件中判断WITH_RPC 才继续执行操作,否则直接返回。

@Zheng-Bicheng
Copy link
Contributor Author

@tianshuo78520a 大佬帮忙approve一下

@tianshuo78520a
Copy link
Contributor

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit a34abdb into PaddlePaddle:develop Mar 28, 2023
@Zheng-Bicheng Zheng-Bicheng deleted the b20 branch March 28, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants