【Hackathon4】No5 nextafter #52544
Merged
【Hackathon4】No5 nextafter #52544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@luotao1 already done. |
jeff41404
reviewed
Apr 21, 2023
jeff41404
reviewed
Apr 21, 2023
jeff41404
reviewed
Apr 21, 2023
jeff41404
reviewed
Apr 21, 2023
jeff41404
reviewed
Apr 21, 2023
|
@jeff41404 all done. |
jeff41404
reviewed
Apr 24, 2023
jeff41404
reviewed
Apr 24, 2023
jeff41404
reviewed
Apr 25, 2023
| def setUp(self): | ||
| self.x = np.random.rand(1, 2).astype('float32') | ||
| self.y = np.random.rand(1, 2).astype('float32') | ||
| self.x1 = np.array([0, 0, 10]).astype("float32") |
There was a problem hiding this comment.
why use 0 in shape? self.x1 does not contain any data, what is the intention of this test case.
There was a problem hiding this comment.
I see pytorch nextafter is using this, so I used it,too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
No5 add nextafter
Chinese Doc: PaddlePaddle/docs#5805
RFC: PaddlePaddle/community#483