Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[框架静态图算子自动生成]add argmax argmin to ops #52562

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

engineer1109
Copy link
Contributor

@engineer1109 engineer1109 commented Apr 5, 2023

PR types

Others

PR changes

OPs

Describe

add argmax argmin to ops.yaml

@paddle-bot
Copy link

paddle-bot bot commented Apr 5, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 5, 2023
@engineer1109 engineer1109 force-pushed the argmax branch 2 times, most recently from 0ed0ea3 to d462046 Compare April 6, 2023 05:08
@engineer1109 engineer1109 changed the title [框架静态图算子自动生成]add argmax to ops [框架静态图算子自动生成]add argmax argmin to ops Apr 6, 2023
paddle/fluid/operators/arg_min_max_op_base.h Show resolved Hide resolved
paddle/fluid/operators/arg_max_op.cc Show resolved Hide resolved
paddle/phi/api/yaml/ops.yaml Show resolved Hide resolved
paddle/phi/api/yaml/ops.yaml Show resolved Hide resolved
paddle/phi/api/yaml/op_compat.yaml Outdated Show resolved Hide resolved
paddle/phi/api/yaml/op_compat.yaml Outdated Show resolved Hide resolved
@engineer1109 engineer1109 force-pushed the argmax branch 2 times, most recently from 415004c to 9e390eb Compare April 6, 2023 07:03
add ops

remove argmin

fix name

remove npu

remove sig
@engineer1109
Copy link
Contributor Author

@heavyrain-lzy 已经修改完了,我自己这里inference和test测试没问题了

Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engineer1109
Copy link
Contributor Author

@zyfncg 看下是否可以Approve

@luotao1 luotao1 merged commit d947b20 into PaddlePaddle:develop Apr 7, 2023
@engineer1109
Copy link
Contributor Author

#51842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants