【Hackathon No.60】prelu, clip_by_norm, multi_dot 算子FP16/BF16单测完善 #52666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Apr 13, 2023
python/paddle/nn/clip.py
Outdated
| @@ -63,7 +63,9 @@ def clip_by_norm(x, max_norm, name=None): | |||
| return _legacy_C_ops.clip_by_norm(x, 'max_norm', max_norm) | |||
|
|
|||
| helper = LayerHelper("clip_by_norm", **locals()) | |||
| check_variable_and_dtype(x, 'X', ['float32', 'float16'], 'clip_by_norm') | |||
| check_variable_and_dtype( | |||
| x, 'X', ['float16', 'float32', 'float64', 'uint16'], 'clip_by_norm' | |||
There was a problem hiding this comment.
CI提示没有double类型，已修改取消float64
ZzSean
reviewed
Apr 13, 2023
|
|
||
| def get_dtype(self): | ||
| self.np_dtype = np.uint16 | ||
| return "float32" |
There was a problem hiding this comment.
这里会把self.dtype设置成float32，应该是uint16
ZzSean
reviewed
Apr 13, 2023
| place, | ||
| ['X', 'Alpha'], | ||
| 'Out', | ||
| max_relative_error=max_relative_error, |
There was a problem hiding this comment.
反向尝试使用默认值，如果无法通过再尝试调整，float16同理
ZzSean
reviewed
Apr 14, 2023
| place, | ||
| ['X', 'Alpha'], | ||
| 'Out', | ||
| max_relative_error=max_relative_error, |
There was a problem hiding this comment.
这样写感觉不太好，建议就直接去掉max_relative_error的设置，使用默认值
ZzSean
reviewed
Apr 14, 2023
| self.check_grad_with_place(self.place, ['x0'], 'Out') | ||
| self.check_grad_with_place(self.place, ['x1'], 'Out') | ||
| except: | ||
| self.check_grad_with_place(self.place, ['x0'], 'Out', atol=0.2) |
There was a problem hiding this comment.
这个从PR贴图来看，差的有点多，建议要么调大numeric_grad_delta或者自己写个user_defined_grad
There was a problem hiding this comment.
已修改增加numeric_grad_delta，测试设置为0.01，设置0.005,0.008测试失败
Aurelius84
approved these changes
Apr 18, 2023
jjyaoao
pushed a commit
to jjyaoao/Paddle
that referenced
this pull request
Apr 19, 2023
…lePaddle#52666) * Add prelu, clip_by_norm, multi_dot tests * Fix code * Fix code
lijialin03
pushed a commit
to lijialin03/Paddle
that referenced
this pull request
Apr 25, 2023
…lePaddle#52666) * Add prelu, clip_by_norm, multi_dot tests * Fix code * Fix code
ZzSean
pushed a commit
to ZzSean/Paddle
that referenced
this pull request
May 5, 2023
…lePaddle#52666) * Add prelu, clip_by_norm, multi_dot tests * Fix code * Fix code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
prelu, clip_by_norm, multi_dot 算子FP16/BF16单测完善
文档修改PR
PaddlePaddle/docs#5789
multi_dot 测试grad误差在0.2
