support adagrad sparse update #5272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kexinzhao
reviewed
Nov 2, 2017
paddle/operators/adagrad_op.cc
Outdated
| @@ -13,6 +13,8 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. */ | |||
|
|
|||
| #include "paddle/operators/adagrad_op.h" | |||
| #include <cmath> | |||
| #include "paddle/operators/math/selected_rows_functor.h" | |||
There was a problem hiding this comment.
Does it make sense to place empty lines before and after #include cmath by following http://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes ?
| @@ -29,25 +37,43 @@ class AdagradOpKernel : public framework::OpKernel<T> { | |||
| param_out_tensor->mutable_data<T>(ctx.GetPlace()); | |||
| moment_out_tensor->mutable_data<T>(ctx.GetPlace()); | |||
There was a problem hiding this comment.
Does it make sense to move lines 26 - 30 into the if else block since they are only used for LoDTensor type?
There was a problem hiding this comment.
Actually, we have to allocate memory before calculating. param_out_tensor->mutable_data<T>(ctx.GetPlace()); have to be called in both if-else block. I will unify the variable name in both if-else block to avoid inconsistence.
kexinzhao
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5271