[Zero-Dim] support dist/cov/det output 0D #52857

GGBond8488 · 2023-04-13T02:39:34Z

PR types

Others

PR changes

Others

Description

Pcard-66984
Support the following api 0D output

paddle.dist
paddle.linalg.cov
paddle.linalg.det

paddle-bot · 2023-04-13T02:39:38Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

… support_OD_output

… support_0d_output_for_linalg.norm_and_slogdet

unique支持float16和bfloat16数据类型，并完善相关单测。

… add_0d_output_support_for_det

zhwesky2010

norm/cond的case先打开吧，但是如果因为依赖sum/mean的地方，可以先写成老版本的shape: (1,) 来跑，但是加个TODO: after sum/mean output 0D, will change to []

zhwesky2010 · 2023-04-23T11:05:05Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        # 1D input, p = fro ,axis = None, using reduceInferMeta
+        x_1 = paddle.arange(24, dtype="float32") - 12
+        x_1.stop_gradient = False
+        # using frobenius_norm, depends on reduce inferMeta support 0d output


reduce inferMeta 已经修改了，可以打开

zhwesky2010 · 2023-04-23T11:06:07Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        self.assertEqual(x_2_fro.grad.shape, [24])
+
+        # 2D input, p = 1, axis = [0, 1]
+        # using p_matrix_norm ,depends on abs, pow, sum


abs/pow都是已经支持0D输入并输出0D的。就依赖sum就可以了。
我修改sum时，再把这个case打开

修改为仅依赖sum

zhwesky2010 · 2023-04-23T11:06:23Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        # self.assertEqual(x_4.grad.shape, [4, 6])
+
+        # 2D input, p = inf, axis = None
+        # using p_matrix_norm, depends on paddle.max, paddle.min


max/min都支持了，可以打开

zhwesky2010 · 2023-04-23T11:06:34Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        # self.assertEqual(x_5.grad.shape, [4, 6])
+
+        # 2D input, p = -inf, axis = [0, 1]
+        # using inf_norm, depends on paddle.max, paddle.min, paddle.abs


max/min都支持了，可以打开
abs也支持

zhwesky2010 · 2023-04-23T11:11:39Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+
+        # x = paddle.to_tensor([[1.0, 0, -1], [0, 1, 0], [1, 0, 1]])
+        # x.stop_gradient = False
+        # p = 2 : use paddle.sum, paddle.max, paddle.min


max/min支持了，可以去掉
sum我修改时再打开这个case

zhwesky2010 · 2023-04-23T11:11:54Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        # out_fro = paddle.linalg.cond(x, p='fro')
+        # assert_shape(out_fro)
+
+        # p = nuc : use paddle.sum, paddle.max, paddle.min


max/min支持了，可以去掉
sum我修改时再打开这个case

zhwesky2010 · 2023-04-23T11:12:07Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        # out_minus_1 = paddle.linalg.cond(x, p=-1)
+        # assert_shape(out_minus_1)
+
+        # p in (-2, 2) :use paddle.max, paddle.min


max/min支持了，可以打开这个case

zhwesky2010 · 2023-04-23T11:36:26Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        # out_minus_inf.backward()
+        # self.assertTrue(x.grad.shape, [3, 3])
+
+        # a = paddle.randn([2, 4, 4])


这个有其他的依赖吗，不然可以打开这个case，如果有依赖需要说明

zhwesky2010 · 2023-04-23T11:36:42Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

@@ -3747,6 +3928,156 @@ def test_multi_dot(self):
        self.assertEqual(res[2].shape, (4, 5))
        self.assertEqual(res[3].shape, (5,))

+    @prog_scope()
+    def test_linalg_norm(self):


静态图同动态图问题一致

zhwesky2010 · 2023-04-23T11:36:52Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        np.testing.assert_array_equal(res[0], np.array(2).astype(np.float32))
+
+    @prog_scope()
+    def test_cond(self):


与动态图问题一致

除依赖sum以外的case全部打开，剩下也标明依赖sum

… add_0d_output_support_for_det

…/Paddle into add_0d_output_support_for_det

zhwesky2010 · 2023-04-26T07:03:43Z

python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py

+        out_2.retain_grads()
+        out_2.backward()
+
+        self.assertEqual(out_2.shape, [1])


这个的shape应该是[]吧

这个就是行为不一样了，我们的多了一个as_vector参数，如果不指定axis，as_vector=True,就会返回1D
指定了axis,as_vector=False 返回了0D 可以看下面那个case

zhwesky2010

LGTM

paddle-bot · 2023-04-28T08:17:38Z

你的PR已合入Paddle库，请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

GGBond8488 added 3 commits April 12, 2023 06:51

add 0d support for dist, trace, paddle.linalg.cond test=allcase

ecd202e

add_0d_output_support_for_det

9f5dfd9

test=allcase

11b8412

GGBond8488 and others added 23 commits April 13, 2023 08:33

support_0d_output_for_linalg.norm

fe49c1b

support linalg.norm 0d output, test=allcase

dc4332c

fix 0D test

667e7a1

fix zero dim test, test=allcase

df25e31

fix 0D test

475bf2f

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

032e3fb

… support_OD_output

fix tets,test=allcase

6142d94

fix error,test=allcase

6e70adf

fix errors ,test=allcase

dd61c63

add static backward , test=allcase

035cadf

add static backwward test, test=allcase

e5146f1

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

13dfb05

… support_0d_output_for_linalg.norm_and_slogdet

fix conflicts

3e87da3

fix pr-ci-build error;test=document_fix (PaddlePaddle#53060)

bdf944b

[Cherry-Pick] Unique support float16&bfloat16 (PaddlePaddle#53023)

00b7c81

unique支持float16和bfloat16数据类型，并完善相关单测。

slogdet_support_0D_output

a8e3aa3

add new case

3ec138d

merge develop

97126d2

fix tests, test=allcase

e3e2abf

merge norm

374a371

merge

58cd314

merge

13928ce

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

cf133b4

… add_0d_output_support_for_det

GGBond8488 changed the title ~~【0D output】add_0d_output_support_for_det~~ 【0D output】add_0d_output_support Apr 20, 2023

GGBond8488 changed the title ~~【0D output】add_0d_output_support~~ 【0D output】add_0D_output_support Apr 20, 2023

fix p_norm related test, test=allcase

21235c7

GGBond8488 mentioned this pull request Apr 23, 2023

Cherry pick 0 d output #53238

Closed

zhwesky2010 reviewed Apr 23, 2023

View reviewed changes

GGBond8488 added 5 commits April 23, 2023 11:45

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

8ed5522

… add_0d_output_support_for_det

open some case, test=allcase

ec56e5f

open some case, test=allcase

6269092

fix conflicts, test=allcase

fd10479

Merge branch 'add_0d_output_support_for_det' of github.com:GGBond8488…

55b8046

…/Paddle into add_0d_output_support_for_det

GGBond8488 force-pushed the add_0d_output_support_for_det branch from 55b8046 to 8138ce6 Compare April 25, 2023 09:48

zhwesky2010 reviewed Apr 26, 2023

View reviewed changes

GGBond8488 added 2 commits April 26, 2023 08:32

fix norm all case, test=allcase

b832793

merge develop

fff8e6e

GGBond8488 force-pushed the add_0d_output_support_for_det branch from ad5e97e to fff8e6e Compare April 27, 2023 02:57

GGBond8488 added 8 commits April 27, 2023 05:18

fix some test error, test=allcase

927e3ec

fix typro,test=allcase

9c9d8c5

fix test err, test=allcase

2400312

test=allcase

7f72ff0

test

254c31f

fix test error, test=allcase

14c3de2

fix test error, test=allcase

d05cd30

fallback norm, test=allcase

16a552d

zhwesky2010 approved these changes Apr 28, 2023

View reviewed changes

zhwesky2010 merged commit ef6e8d0 into PaddlePaddle:develop Apr 28, 2023
24 checks passed

paddle-bot bot added the status: accepted label Apr 28, 2023

zhwesky2010 changed the title ~~【0D output】add_0D_output_support~~ 【Zero-Dim】support dist/cov/det output 0D Apr 28, 2023

zhwesky2010 mentioned this pull request May 6, 2023

[Paddle] 0维Tensor推全 PaddlePaddle/PaddleCustomDevice#515

Closed

YanhuiDua mentioned this pull request May 6, 2023

[NPU] support zero_dims tensor PaddlePaddle/PaddleCustomDevice#542

Merged

This was referenced May 7, 2023

[Cherry-pick]Cherry pick 0d output #53538

Merged

fix and open 0D output optest PaddlePaddle/PaddleTest#2209

Merged

zhwesky2010 changed the title ~~【Zero-Dim】support dist/cov/det output 0D~~ [Zero-Dim] support dist/cov/det output 0D May 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Zero-Dim] support dist/cov/det output 0D #52857

[Zero-Dim] support dist/cov/det output 0D #52857

GGBond8488 commented Apr 13, 2023 •

edited by zhwesky2010

paddle-bot bot commented Apr 13, 2023

zhwesky2010 left a comment

zhwesky2010 Apr 23, 2023

GGBond8488 Apr 24, 2023

zhwesky2010 Apr 23, 2023

GGBond8488 Apr 24, 2023

zhwesky2010 Apr 23, 2023

zhwesky2010 Apr 23, 2023

zhwesky2010 Apr 23, 2023

zhwesky2010 Apr 23, 2023

zhwesky2010 Apr 23, 2023

zhwesky2010 Apr 23, 2023

zhwesky2010 Apr 23, 2023

zhwesky2010 Apr 23, 2023

GGBond8488 Apr 24, 2023

zhwesky2010 Apr 26, 2023

GGBond8488 Apr 26, 2023

zhwesky2010 left a comment •

edited

paddle-bot bot commented Apr 28, 2023

[Zero-Dim] support dist/cov/det output 0D #52857

[Zero-Dim] support dist/cov/det output 0D #52857

Conversation

GGBond8488 commented Apr 13, 2023 • edited by zhwesky2010

PR types

PR changes

Description

paddle-bot bot commented Apr 13, 2023

zhwesky2010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 left a comment • edited

Choose a reason for hiding this comment

paddle-bot bot commented Apr 28, 2023

GGBond8488 commented Apr 13, 2023 •

edited by zhwesky2010

zhwesky2010 left a comment •

edited