【Hackathon4 No.61】remainder 算子FP16/BF16单测完善 #52920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
enkilee
changed the title
enkilee
changed the title
|
Sorry to inform you that 566cec1's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
ZzSean
reviewed
May 5, 2023
ZzSean
reviewed
May 5, 2023
| checker=self.verify_output, place=place | ||
| ) | ||
|
|
||
| def verify_output(self, outs): |
There was a problem hiding this comment.
不管是用np.mod还是np.fmod，rtol都到了300以上
There was a problem hiding this comment.
由于数据类型所限，使用fp32计算和使用bf16的结果差距太大，这里可以对输入做一些处理，初始化为FP32->convert为bf16->convert为fp32，即convert_uint16_to_float(convert_float_to_uint16(x))然后再计算参考结果，这样应该是可以通过的，无需使用自定义函数
…e/Paddle into hackathon4-No61-remainder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
remainder