-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon No.61】uniform_random 算子FP16/BF16单测完善 #52949
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
@@ -1,3 +1,4 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删除无效改动
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
self.op_type = "uniform_inplace" | ||
self.dtype = np.float16 | ||
self.shape = (1000, 784) | ||
x = paddle.ones(self.shape, dtype=self.dtype) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
数据初始化使用random
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
ccc13da
to
9d6308d
Compare
|
||
def verify_output(self, outs): | ||
hist, prob = self.output_hist(np.array(outs[0])) | ||
np.testing.assert_allclose(hist, prob, rtol=0, atol=0.01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atol使用1e-3能否通过?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZzSean 修改CI已完成 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
self.place, | ||
['X'], | ||
'Out', | ||
check_dygraph=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问两个单测为什么要设置 check_dygraph=False 呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试提示错误设置python_api,生成是随机数,没有paddle.uniform_random_inplace可以设置
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@co63oc 辛苦
- 再merge下develop,CI 超过7天会设置部分失败
- 加一个备注的todo,说由于缺少paddle.uniform_random_inplace的设置,暂时把动态图的测试给关了
Sorry to inform you that 0908d08's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for check_dygraph
PR types
Others
PR changes
Others
Description
uniform_random 算子FP16/BF16单测完善