add clip_by_norm op #5296
Merged
add clip_by_norm op #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Nov 3, 2017
paddle/operators/clip_by_norm_op.cc
Outdated
| framework::OpAttrChecker* op_checker) | ||
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput("X", | ||
| "(Tensor)The input of clip_by_norm op." |
There was a problem hiding this comment.
Need a space between (Tensor) and The. Same as below doc.
(Tensor) The
paddle/operators/clip_by_norm_op.h
Outdated
| using EigenVector = framework::EigenVector<T, MajorType, IndexType>; | ||
| template <typename T, int MajorType = Eigen::RowMajor, | ||
| typename IndexType = Eigen::DenseIndex> | ||
| using EigenScalar = framework::EigenScalar<T, MajorType, IndexType>; |
There was a problem hiding this comment.
If EigenScalar is not used, it can be removed.
paddle/operators/clip_by_norm_op.cc
Outdated
| ctx->SetOutputDim(framework::GradVarName("X"), x_dims); | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
If this Op has no gradient op, the ClipByNormOpGrad can be removed.
qingqing01
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4662
Clipping the gradient, only forward pass is needed.