【prim】Elementwise double grad #53014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… elementwise_double_grad
JiabinYang
reviewed
Apr 24, 2023
| this->GetSingleInputGrad(framework::GradVarName("Out")); | ||
|
|
||
| // get attr | ||
| int axis = static_cast<int>(this->Attr<int>("axis")); |
|
|
||
| // get attr | ||
| int axis = static_cast<int>(this->Attr<int>("axis")); | ||
| PADDLE_ENFORCE_EQ( |
JiabinYang
reviewed
Apr 24, 2023
python/paddle/fluid/backward.py
Outdated
| name | ||
| for name in op_desc.input_arg_names() | ||
| if is_grad_name(name) | ||
| ] | ||
| if len(input_grad_names) == 0: |
There was a problem hiding this comment.
modify by cxxly
zyfncg
reviewed
Apr 24, 2023
| const Tensor& grad_out, | ||
| const paddle::optional<Tensor>& grad_x_grad, | ||
| const paddle::optional<Tensor>& grad_y_grad, | ||
| int axis, |
There was a problem hiding this comment.
如果已经在maker处强制要求axis为-1，这里的axis参数是不就可以去掉了？
There was a problem hiding this comment.
函数签名需要和yaml 配置严格一致
| const Tensor& grad_out, | ||
| const paddle::optional<Tensor>& grad_x_grad, | ||
| const paddle::optional<Tensor>& grad_y_grad, | ||
| int axis, |
| @@ -114,5 +114,23 @@ static std::vector<DST_T> unsafe_vector_cast(const std::vector<SRC_T>& src) { | |||
| return dst; | |||
| } | |||
|
|
|||
| // This fucction compute unsqueeze dims for reshape to replace unsqueeze. | |||
| static std::vector<int> get_unsqueeze_dims(const Tensor& origin, | |||
| const IntArray& axis) { | |||
There was a problem hiding this comment.
这里用IntArray是需要支持Tensor类型的参数吗？
There was a problem hiding this comment.
不需要，此函数代替unsqueeze算子，对齐unsqueeze 算子的输入类型
| @@ -0,0 +1,334 @@ | |||
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
next PR will modify
… elementwise_double_grad
xiaoguoguo626807
commented
May 6, 2023
zyfncg
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-66975
拆解 elementwise系列算子二阶，使得科学计算模型不需要开启prim_flag即可完成无限阶高阶计算