Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 4】No.63 : add lerp bf16 support #53078

Merged
merged 14 commits into from
Jul 3, 2023
Merged

【PaddlePaddle Hackathon 4】No.63 : add lerp bf16 support #53078

merged 14 commits into from
Jul 3, 2023

Conversation

longranger2
Copy link
Contributor

@longranger2 longranger2 commented Apr 19, 2023 •
edited

PR types

Others

PR changes

APIs

Description

  • add lerp bf16 support

相关链接：
#51281
修改的中文文档链接🔗如下：
PaddlePaddle/docs#5993

@paddle-bot
Copy link

paddle-bot bot commented Apr 19, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 19, 2023
@longranger2
Update test_lerp_op.py
739d6e7 
modify the input dtype
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Apr 30, 2023

Sorry to inform you that 739d6e7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@longranger2
Copy link
Contributor Author

@ZzSean @Vvsmile 辛苦帮忙review下～，
PR-CI-Windows-Inference这里报错，但我反复检查过代码，没有发现是哪里出现了问题

image

@longranger2 longranger2 reopened this May 16, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 16, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@longranger2 longranger2 mentioned this pull request May 18, 2023
Closed
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jun 7, 2023

Sorry to inform you that 0444f78's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zhangting2020 zhangting2020 mentioned this pull request Jun 26, 2023
Closed
@longranger2
Copy link
Contributor Author

@zhangting2020 辛苦review下～

zhangting2020
zhangting2020 reviewed Jun 27, 2023
View reviewed changes
test/legacy_test/test_lerp_op.py
np.ones(self.yshape)
* w
/ (np.prod(self.yshape) / np.prod(self.wshape))
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里必须使用自定义梯度吗？使用单测系统得到的期望梯度存在什么问题吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，使用单测系统得到的期望梯度会报错

zhangting2020
zhangting2020 previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangting2020
Copy link
Contributor

还有一点小问题：

@longranger2 longranger2 mentioned this pull request Jun 29, 2023
Merged
@longranger2
Copy link
Contributor Author

@zhangting2020 辛苦review下～

@luotao1 luotao1 merged commit ce31a72 into PaddlePaddle:develop Jul 3, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangting2020 zhangting2020 zhangting2020 approved these changes

Assignees

@luotao1 luotao1

@Vvsmile Vvsmile

@zhangting2020 zhangting2020

@ZzSean ZzSean

@Ligoml Ligoml

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@longranger2 @zhangting2020 @luotao1 @Vvsmile @ZzSean @Ligoml